Skip to content

fix: replace hard coded components path with the resolved path#1612

Closed
Slartibartfass2 wants to merge 1 commit into
huntabyte:nextfrom
Slartibartfass2:fix/fix-hard-coded-components-path-in-update-cli-command
Closed

fix: replace hard coded components path with the resolved path#1612
Slartibartfass2 wants to merge 1 commit into
huntabyte:nextfrom
Slartibartfass2:fix/fix-hard-coded-components-path-in-update-cli-command

Conversation

@Slartibartfass2
Copy link
Copy Markdown

@Slartibartfass2 Slartibartfass2 commented Jan 11, 2025 •
edited
Loading

Closes #1532

Previously, anybody who didn't use the default components.json couldn't execute the update because if the ui path had been changed, this would resolve in an exception. Now the resolved alias path from the components.json is used.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6890047

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Slartibartfass2
fix: replace hard coded components path with the resolved path
6890047 
Previously, anybody who didn't use the default components.json couldn't execute the update because if the ui path had been changed, this would resolve in an exception. Now the resolved alias path from the components.json is used.
@Slartibartfass2 Slartibartfass2 force-pushed the fix/fix-hard-coded-components-path-in-update-cli-command branch from abd17e9 to 6890047 Compare January 11, 2025 19:34
@Slartibartfass2
Copy link
Copy Markdown
Author

Slartibartfass2 commented May 16, 2025

@huntabyte Hi there, is there any problem with this PR? It has been a while since it was opened.

@huntabyte
Copy link
Copy Markdown
Owner

huntabyte commented May 16, 2025

Hey @Slartibartfass2, we have reworked a lot of the internals of the CLI in the next-tailwind-4 PR to support custom registries and whatnot. @AdrianGonz97 what do you think about this?

@AdrianGonz97
Copy link
Copy Markdown
Collaborator

AdrianGonz97 commented May 28, 2025

Apologies for the delay! This should already be resolved as of shadcn-svelte@1.0.0-next.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdrianGonz97 AdrianGonz97 Awaiting requested review from AdrianGonz97

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Slartibartfass2 @huntabyte @AdrianGonz97